Auto Sell/Display Pumpkin/Melon Macro Mod

Omg so useful thanks

 

this is an amazing macro. It is so helpful being able to auto sell it

 

This is a really cool macro, well done! If you don't mind, there are some suggestions I'd like to make ^-^

Spoiler: Suggestions

For this, all you need to do is: $$<Loops.txt>. (Or, if the $${ and }$$ aren't in Loops.txt, you can do $${$$<Loops.txt>}$$)

I noticed you didn't use percent signs around any variable names (such as PICKUPAMOUNT.) As far as I know, you have to, but your macro seems to work without doing so I would put them though, because you should have to (I think...)

You also entered the condition as PICKUPITEM = "Pumpkin". As far as I'm aware, PICKUPITEM isn't a variable, it's PICKUPID... but again, apparently your macro works

And, finally, in your ECHO commands, you didn't put quotes around the message (/sell pumpkin.) I, again, was under the impression that it was necessary to do so, but if you've tested the macro and it works, it's apparently not necessary... I would still do it though, just for the sake of style.

I can't test at the moment because I can't go on Minecraft, but I would think at least one of these would work: The first is obviously the best, since you're using its actual worth (.4 dollars). However, if decimals don't work for some reason, the second example below should work (since 2/5 = .4)

1. @#worth = %PICKUPAMOUNT% * .4;
2. @#worth = %PICKUPAMOUNT% * 2 / 5;

For this, I would recommend just making a text file with the code in it, because (for me, at least) that makes it easier to a) edit it and b) see what's actually going on--readable code is always good
Also, I'm not sure why you made it two separate scripts... it should work as only one script, I believe. Basically, I would recommend something like this:

Spoiler: Conditional Macro Code

Code:

$${
@#pumpkin = @#pumpkin + %PICKUPAMOUNT%;
@#worth = @#worth + %PICKUPAMOUNT% * .4;
IF(@#pumpkin >= 1000);
    ECHO("/sell pumpkin");
    @#pumpkin = 0;
    @#worth = 0;
ENDIF;
}$$

And then, again, all you would have to do is bind it to onItemPickup next to "IF TRUE" using $$<fileName.txt>.

If you didn't want to use the conditional macro thing, and just wanted to use the regular one, you could also do this:

Spoiler: Normal Macro Code

Code:

$${
IFMATCHES(%PICKUPID%, "pumpkin");
    @#pumpkin = @#pumpkin + %PICKUPAMOUNT%;
    @#worth = @#worth + %PICKUPAMOUNT% * .4;
    IF(@#pumpkin >= 1000);
        ECHO("/sell pumpkin");
        @#pumpkin = 0;
        @#worth = 0;
    ENDIF;
ENDIF;
}$$

And you would just bind it like above, except in the normal macro tab.

Again, I haven't tested any of this code because I can't go on Minecraft at the moment, but I'm fairly sure it should work If it doesn't, just let me know and I'll see what I can do, I don't have a great track record of making macros work on the first try

If you didn't want input, sorry I just like to help if I can (and hopefully this was somewhat helpful... maybe...)

 

Alrighty so I did a thing I tested it and everything, and I also got it all in one script (setting the labels), because it was inefficient to run on a constant loop like that. So, the final product:

Spoiler: Code and some other stuff

Code:

$${
IFMATCHES(%PICKUPID%, "pumpkin");
    @#pumpkin = %@#pumpkin% + %PICKUPAMOUNT%;
    @#worth = (%@#pumpkin% * 2) / 5;
    IF(@#pumpkin >= 1000);
        ECHO("/sell pumpkin");
        @#pumpkin = 0;
        @#worth = 0;
    ENDIF;
    SETLABEL(Worth, "Worth: %@#worth%");
    SETLABEL(Amount, "Pumpkins: %@#pumpkin%");
ENDIF;
}$$

As far as I can figure, decimals just aren't supported at all in the macro mod. What it does instead is takes the number with a decimal and cuts it off just before the decimal--not rounding, but similar. I.e., 62.20 would become 62 (it just cuts off the decimal), but 62.8 would also become 62, not 63 (even though it's closer to 63.) The result is that the script just displays the worth of the pumpkins to the nearest whole number, but always rounds down. However, the most it's ever off by is 80 cents, so it shouldn't be too much of an issue, I don't think

In your original post, you said both @#pumpkin and @#worth got set to zero when you joined the server, but I didn't see anywhere in your code where that happened. It would be very simple to do (as would setting both variables to zero whenever you enter the "/sell pumpkin" command), but that would require binding a script to onJoinGame and onSendChat respectively, and I wasn't sure if you wanted to have to deal with multiple scripts like that If you don't do that, there's no need to make the variables global (with the @ prefix), but I left it in case you want to do anything in different script.

If this works for you, feel free to use it, and if not, I'll try to fix whatever bugs there are. It seemed to work pretty well for me

 

this is cool :O you should do something like this for cocoa

 

Glad to hear it if there's anything else I can help with, feel free to let me know

 

best macro m8