+1

 

+1

 

+1 It's impossible to know if you're hitting someone if they have spy, unless they're wearing armor.

 

Also, this would prevent the potion effect before grace period which is extremely annoying. +1

 

+1

 

+1

 

+1



Sent from my iPhone using Tapatalk

 

+1 Helpful

 

+1 I also notice quite often the spy user won't even take damage, especially if two people in spy are fighting eachother.

 

In essence, their entire body turns red? That's how I always imagined it. +1

 

+314!

 

Feel free to mock up the code change you want.

Sent from my Nexus 5 using Tapatalk

 

I like this idea, but we should keep it so you can see them turn red when they are hit (they as in /kit spy users).

+1

 

Just so you know, I'm not being flippant, I just have no idea what you actually want.

Background info: the the splash effect is currently triggered by EntityDamageByEntityEvent and triggers at EventPriority.HIGHEST.
The code double checks that both entities are players, and that the player being hit is invisible, is there some other stipulation that needs added?

The purpose of the effect is to give you a rough idea of when you actually succeed at hitting the player, so you have a rough idea of the location of a invisible player.

 

Why would it be possible to hit but not deal damage...

I've added:

if (event.getDamage() < 1) { return; }

See if that fixes the issue, the change will probably be applied next restart.

 

Hmm, would it be possible to have the invisible user's body turn red instead of the splash potion. For example, they become visible for a second or two and they're just a light red. Would that be possible?

 

While I have made the tweak in the post above, which could be considered a bug fix if it does anything, since the code is currently only supposed to show splashes on damage.

In what situations would a player ever be hit, but not take damage? I'm not talking about client side glitches which cause client local particle effects, this splash damage is done when the server registers a hit. There should be no situations where a hit doesn't cause damage?

Additionally if this does fix it, surely this is a bad thing, since it means it will be harder to find invisible players?